[BugFix][Relay] skip leaf args when matching 'path' part for dominator pattern#16983
Merged
wrongtest-intellif merged 2 commits intoapache:mainfrom Jun 21, 2024
Merged
Conversation
399bcb3 to
2bfdb17
Compare
2bfdb17 to
8fd3348
Compare
Contributor
Author
|
Some changes are made to fix an issue of matching dominator pattern. Could you help review this? cc @wrongtest-intellif @kfeng123 |
8fd3348 to
26856ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch for PR #15473
That PR tried to solve the issues described in RFC, but introduced another issue, probably unintentionally.
The new issue occurs, when there are some leaf args of some OPs along the path during matching 'path' part for dominator pattern. For example, suppose we have a dominator pattern as follows:
and we want to match the graph:
The pattern should match this graph since
conv2ddominatesreshapealongbias_add+relu, provided that we accept the original definition of "dominator" in TVM. But the change in PR #15473 makes the matching fail because it treatsbiasas an addtional path.This is fixed by skipping the leaf arguments when matching the 'path' part of the dominator pattern.
The issue may be rooted in some confusion of the definition of "dominator" in TVM, as described in this post. But at present, since the original definition of "dominator" remains unchanged in the real codebase, I think my patch may still make sense.